Skip to content

feat(mistica-css): switch#1364

Merged
atabel merged 3 commits into
masterfrom
atoledano-css-switch
May 19, 2025
Merged

feat(mistica-css): switch#1364
atabel merged 3 commits into
masterfrom
atoledano-css-switch

Conversation

@atabel
Copy link
Copy Markdown
Contributor

@atabel atabel commented May 8, 2025

Comment thread css/mistica-common.css
border-color var(--switch-transition);
}

.mistica-switch:after {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:after is the handle (bolita)

Comment thread css/mistica-common.css
transform: translateX(20px) scale(1.75);
}

.mistica-switch:before {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:before is the "ripple effect" overlay on hover

Comment thread css/mistica-common.css
Comment on lines +924 to +926
.mistica-accordion-item__summary::-webkit-details-marker {
display: none;
}
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated, this fixes accordion in safari

Comment thread examples/css/index.html Outdated
<h4 class="mistica-text-title1">MediaCard / DataCard / SnapCard</h4>
<div class="cards-group">
<section class="mistica-card">
<div class="mistica-card__asset-floating" style="border-radius: 50%; height:40px; width: 40px; background: var(--mistica-color-tagBackgroundActive)">
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated prettier formatting changes

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2025

Size stats

master this branch diff
Total JS 12.4 MB 12.4 MB 0 B
JS without icons 2.12 MB 2.12 MB 0 B
Lib overhead 77.6 kB 77.6 kB 0 B
Lib overhead (gzip) 17.6 kB 17.6 kB 0 B

Comment thread css/mistica-common.css Outdated
width: 52px;
height: 32px;
border-radius: 16px;
background-color: var(--mistica-color-backgroundContainerAlternative);
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aweell, we may need some changes in color constants. I tried the ones in the spec and they don't work well, specially for the handle (bolita).

Also, these colors don't work well over inverse

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline, spec pending to be updated to fix color issues

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specs have been updated: https://www.figma.com/design/J0LzwXn0tzGNIkgvFnt0Yz/%F0%9F%94%B8-Switch-Component-Specs?m=auto&node-id=0-1004&t=QFFsCmhXQlZbtzQ9-1

We have decided removing the color change in the active handle hover state to avoid the need of creating new tokens.

I've been testing the spec changes in: https://mistica-web-jpho-mqzqgjrhh-alex-buenos-projects.vercel.app/mistica-css

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes applied

@atabel atabel changed the title WEB-2190 feat(mistica-css): switch feat(mistica-css): switch May 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2025

Accessibility report
✔️ No issues found

ℹ️ You can run this locally by executing yarn audit-accessibility.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2025

Deploy preview for mistica-web ready!

✅ Preview
https://mistica-jz0h07y0m-flows-projects-65bb050e.vercel.app

Built with commit 2226542.
This pull request is being automatically deployed with vercel-action

@atabel atabel added this pull request to the merge queue May 19, 2025
Merged via the queue into master with commit 7b6df80 May 19, 2025
11 checks passed
@atabel atabel deleted the atoledano-css-switch branch May 19, 2025 10:59
tuentisre pushed a commit that referenced this pull request May 28, 2025
# [16.26.0](v16.25.0...v16.26.0) (2025-05-28)

### Features

* **mistica-css:** counter ([#1372](#1372)) ([70d8beb](70d8beb))
* **mistica-css:** ErrorFeedbackScreen ([#1371](#1371)) ([99ea3cf](99ea3cf))
* **mistica-css:** slider ([#1374](#1374)) ([89c6aee](89c6aee))
* **mistica-css:** switch ([#1364](#1364)) ([7b6df80](7b6df80))
* **mistica-css:** TextField / SearchField ([#1370](#1370)) ([55781c4](55781c4))
* **RowList, BoxedRowList, Stack:** O2DE-7699 RowList with aria-live and aria-atomic attributes ([#1376](#1376)) ([5070c61](5070c61))
@tuentisre
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 16.26.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants